Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude default/empty values from spec during a read operation #143

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

michaelhtm
Copy link
Member

Issue #2230

Description of changes:
This PR is ensuring the controller does not assign default empty
values to the resource during a read operation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly December 17, 2024 18:14
@michaelhtm michaelhtm force-pushed the exclude-defaults branch 4 times, most recently from 8481230 to 1df5eb1 Compare December 17, 2024 20:38
Copy link

ack-prow bot commented Dec 17, 2024

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-verify-attribution f913d0a link false /test s3-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 17, 2024

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link

ack-prow bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 14972d4 into aws-controllers-k8s:main Dec 17, 2024
6 of 7 checks passed
a-hilaly added a commit that referenced this pull request Jan 14, 2025
ack-prow bot pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants